lightning icon indicating copy to clipboard operation
lightning copied to clipboard

Upgrade Elixir to 1.18 and OTP to 27

Open stuartc opened this issue 1 year ago • 5 comments

Description

This PR upgrades the Elixir version to 1.18.3 and OTP to 27.3.3

Closes #3153

Validation steps

  1. clone the repo
  2. run /bin/bootstrap
  3. run mix test

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • [ ] Code generation (copilot but not intellisense)
  • [ ] Learning or fact checking
  • [ ] Strategy / design
  • [ ] Optimisation / refactoring
  • [ ] Translation / spellchecking / doc gen
  • [ ] Other
  • [x] I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • [x] I have performed a self-review of my code.
  • [x] I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • [ ] I have updated the changelog.
  • [x] I have ticked a box in "AI usage" in this PR

stuartc avatar Dec 04 '24 13:12 stuartc

@stuartc Happy for me to push this over the finish line?

rorymckinley avatar Apr 02 '25 11:04 rorymckinley

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.45%. Comparing base (a6ee153) to head (db96113).

Files with missing lines Patch % Lines
lib/lightning_web/live/dev/components_live.ex 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2748      +/-   ##
==========================================
- Coverage   91.51%   91.45%   -0.07%     
==========================================
  Files         359      359              
  Lines       13632    13672      +40     
==========================================
+ Hits        12476    12504      +28     
- Misses       1156     1168      +12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 03 '25 11:04 codecov[bot]

PS: I can't see what Codecov is complaining about :)

rorymckinley avatar Apr 03 '25 11:04 rorymckinley

PS: I can't see what Codecov is complaining about :)

Hmm looks likes indirect changes, they look innocuous to me.

stuartc avatar Apr 08 '25 12:04 stuartc

@rorymckinley , @stuartc has identified a possible cause in his environment and asked us to move on with this. I could compile on Mac without any intervention.

We've agreed upon upgrading Elixir to 1.18, for the extended type checking. Would you like to give it a try with the 1.18 as well?

jyeshe avatar Apr 25 '25 14:04 jyeshe