ClusterODM icon indicating copy to clipboard operation
ClusterODM copied to clipboard

[Feature Request]: `docker-machine` is deprecated, we need to add support for another tool for autoscaling

Open gromain opened this issue 3 years ago • 7 comments

docker-machine is being deprecated and starts to be unavailable from repositories. It's also not compatible with the latest docker version. See https://github.com/docker/machine/issues/4537 and https://github.com/docker/roadmap/issues/245 .

One alternative would be to move towards Terraform. There is a provider for Scaleway, so we wouldn't lose functionality. Is there any interest in moving towards this solution?

What is the problem?

docker-machine being deprecated.

What should be the expected behavior?

Not losing the autoscale!

How can we reproduce this? (What steps did you do to trigger the problem? If applicable, please include multiple screenshots of the problem! Be detailed)

Try installing docker-machine on a recent OS.

gromain avatar Feb 01 '22 14:02 gromain

A python alternative could be libcloud (I know this tool is written in JS, just mentioning this for posterity): https://libcloud.apache.org/

gromain avatar Feb 01 '22 14:02 gromain

Definitely interested in possible approaches to migrate away from docker-machine, although docker-machine is open source, so it continues to receive support from various organizations (e.g. gitlab https://gitlab.com/gitlab-org/ci-cd/docker-machine) and has been working OK thus far, so I don't think we're losing autoscaling anytime soon.

pierotofy avatar Feb 01 '22 15:02 pierotofy

Ah yes, this is good then! Maybe we can just update the Readme to point to this new repo, instead of towards https://docs.docker.com/machine/install-machine/ . It was really confusing for me!

gromain avatar Feb 01 '22 16:02 gromain

I've fixed the documentation, Dockerfile and docker-compose files. This will do for now, but I suggest we keep this open to make sure the tool is not completely abandoned by Gitlab and we keep looking for another solution.

gromain avatar Feb 01 '22 21:02 gromain

Thanks. As a heads up, I've reverted the docker-compose file changes since not everyone uses the autoscaling functionality (perhaps those changes should be part of a separate docker-compose file).

pierotofy avatar Feb 01 '22 23:02 pierotofy

Oh I see, I thought the docker-composer file here was only for the autoscaler (since this was in the autoscaler section of the readme too and there is specific instructions about starting it up with one child nodeodm). I'll create a separate one and update the readme accordingly.

gromain avatar Feb 02 '22 00:02 gromain

A python alternative could be libcloud (I know this tool is written in JS, just mentioning this for posterity): https://libcloud.apache.org/

@pierotofy Can we not migrate to Terraform? It is very widely supported.

theoway avatar Jul 22 '22 13:07 theoway