OpenAdapt
OpenAdapt copied to clipboard
Fix/window event race condition
What kind of change does this PR introduce?
a bugfix for #816
Summary
- removed data from
WindowEventmodel and created a new modelA11yEventwhich points to the relevantWindowEvent - updated
crud.pyby adding insert_a11y_event - made changes in
record.pywhere we usequeueto map whichWindowEventis waiting for its correspondingA11yEvent
Checklist
- [x] My code follows the style guidelines of OpenAdapt
- [x] I have performed a self-review of my code
- [ ] If applicable, I have added tests to prove my fix is functional/effective
- [ ] I have linted my code locally prior to submission
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
- [ ] New and existing unit tests pass locally with my changes
@Animesh404 please consolidate the alembic scripts into a single migration. You can do this by downgrading the two that you have currently applied:
alembic downgrade -2
Then generate a new revision, add it, and remove the existing ones.
Thanks @Animesh404 ! Can you please show screenshots of a11y events in visualize.py and the dashboard?
Thanks @Animesh404 ! Can you please show screenshots of a11y events in visualize.py and the dashboard?
Sure @abrichr
- Dashboard
- Visualize
@Animesh404 please correct me if I'm wrong but I don't see any accessibility data in the dashboard screenshot
@Animesh404 please correct me if I'm wrong but I don't see any accessibility data in the dashboard screenshot
added here 3b0ada0