OpenAdapt icon indicating copy to clipboard operation
OpenAdapt copied to clipboard

Fix/window event race condition

Open Animesh404 opened this issue 1 year ago • 5 comments

What kind of change does this PR introduce?

a bugfix for #816

Summary

  • removed data from WindowEvent model and created a new model A11yEvent which points to the relevant WindowEvent
  • updated crud.py by adding insert_a11y_event
  • made changes in record.py where we use queue to map which WindowEvent is waiting for its corresponding A11yEvent

Checklist

  • [x] My code follows the style guidelines of OpenAdapt
  • [x] I have performed a self-review of my code
  • [ ] If applicable, I have added tests to prove my fix is functional/effective
  • [ ] I have linted my code locally prior to submission
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • [ ] New and existing unit tests pass locally with my changes

Animesh404 avatar Jul 08 '24 19:07 Animesh404

@Animesh404 please consolidate the alembic scripts into a single migration. You can do this by downgrading the two that you have currently applied:

alembic downgrade -2

Then generate a new revision, add it, and remove the existing ones.

abrichr avatar Jul 18 '24 23:07 abrichr

Thanks @Animesh404 ! Can you please show screenshots of a11y events in visualize.py and the dashboard?

abrichr avatar Jul 25 '24 18:07 abrichr

Thanks @Animesh404 ! Can you please show screenshots of a11y events in visualize.py and the dashboard?

Sure @abrichr

  • Dashboard image
  • Visualize image

Animesh404 avatar Jul 25 '24 20:07 Animesh404

@Animesh404 please correct me if I'm wrong but I don't see any accessibility data in the dashboard screenshot

abrichr avatar Jul 25 '24 20:07 abrichr

@Animesh404 please correct me if I'm wrong but I don't see any accessibility data in the dashboard screenshot

image added here 3b0ada0

Animesh404 avatar Jul 29 '24 16:07 Animesh404