openapi-generator-cli
openapi-generator-cli copied to clipboard
OpenAPITools
Replace deprecated HttpModule from @nestjs/common with @nestjs/axios
As the new axios HttpModules respects the environment variables HTTP_PROXY, HTTPS_PROXY and NO_PROXY, there is no need to configure it explicitly anymore.
This fixes issue #390
@wing328 @kay-schecker As you merged the last PRs in this repo - do you know who might be able to review this PR and decide if it can be merged?
@rishabh1212 That is out of my hands, I'm afraid. I just did a peer review...
Sorry for the delay in reviewing this change.
Please take a look at the build errors.
Not sure if it's related to https://github.com/OpenAPITools/openapi-generator-cli/pull/651/commits/49b383b705d3c7d87449387ef439f3add5eba058.
Once resolved, I'll try to handle it with higher priority.
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2, actions/setup-node@v2
I think that's probably the reason.
Please update the github workflow accordingly as part of this PR. Thank you.
@wing328 Thank you so much for the review (& for already merging the master for me)
The problem with the failing pipeline was me not having executed yarn install properly which made "yarn --frozen-lock" fail because of differences in the yarn.lock-file. Now that I did that properly and fixed the yarn.lock-file it should be successful.
Although the node version should not have been a problem, I looked into it. I upgraded all github actions and it looks like you use a matrix build strategy but did not define the values to be used for the node-version. I added the node version 16.x which should use version 16 with the latest minor and patch version. So in the future it can be assured to run with multiple versions.
Seems as if there is an approval needed for the pipeline to run, so let's see if it is successful now.
@wing328 @keks42 it is still awaiting approval from some reviewer who has the write access.
@wing328 Thanks for the approval! :) What is missing now for all the checks to complete? I do not understand the last thing that is still expected :/
No idea why the last step stuck at build state.
I've gone ahead to merge it. Let's see how that goes.
Thanks again for the PR.