owa-php-sdk icon indicating copy to clipboard operation
owa-php-sdk copied to clipboard

fixed a bug and created a way to turn off debug logs

Open daemon-byte opened this issue 3 years ago • 5 comments

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [x] Tested the changes

Pull request type

Please check the type of change your PR introduces:

  • [x] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Docs need to be updated?

  • [ ] Yes
  • [x] No

Other information

daemon-byte avatar Mar 21 '22 09:03 daemon-byte

Not sure why we would modify the sdk::debug method signature and all instances of use when we could just check for the debug setting inside the sdk::debug method.

padams avatar Apr 27 '22 05:04 padams

Makes sense to me. I don't remember why I did it this way

daemon-byte avatar Apr 27 '22 12:04 daemon-byte

Ok. If you revert that change or fix it in your PR and I can merge.

On Apr 27, 2022, at 5:10 AM, Robert Neve @.***> wrote:

 Makes sense to me. I don't remember why I did it this way

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.

padams avatar Apr 27 '22 15:04 padams

Any chance you want to make this final change so I can merge the PR?

padams avatar May 11 '22 18:05 padams

I think we can close this as the same functionality is now in the code.

padams avatar Dec 02 '22 05:12 padams