onesignal-node-api icon indicating copy to clipboard operation
onesignal-node-api copied to clipboard

Export ConfigurationParameters

Open bbenoist opened this issue 1 year ago • 0 comments
trafficstars

Description

One Line Summary

I've exported the ConfigurationParameters from the lib so that it can be reused by dependees.

Details

Motivation

I'm wrapping OneSignal in a NestJS configurable module.

For now, the only way to do it is:

export type OneSignalConfigurationParameters = Parameters<
  typeof createConfiguration
>[0];

Scope

Only TypeScript types are affected.

Other

If possible, please release a new version once this PR gets merged 🙏

Testing

Manual testing

No tests are needed for this PR since this is only a new type export.

Checklist

Overview

  • [x] I have filled out all REQUIRED sections above
  • [x] PR does one thing
  • [x] Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • [x] I have personally tested this on my device, or explained why that is not possible

Final pass

  • [x] Code is as readable as possible.
  • [x] I have reviewed this PR myself, ensuring it meets each checklist item

bbenoist avatar Aug 27 '24 09:08 bbenoist