onesignal-node-api icon indicating copy to clipboard operation
onesignal-node-api copied to clipboard

fix(auth): update authorization header to `Basic`

Open EinfachHans opened this issue 1 year ago • 0 comments

Description

One Line Summary

This PR updates the authorization header from Bearer to Basic

Details

Motivation

Some users start to receive many 401 error. For me the support mentioned that the api changed it's authentication type to basic. This pr reflects this change.

Scope

Authentication

Other

closes #84

Testing

Manual testing

Not tested something here, let me know if this is needed.

Checklist

Overview

  • [X] I have filled out all REQUIRED sections above
  • [X] PR does one thing
  • [X] Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • [ ] I have personally tested this on my device, or explained why that is not possible

Final pass

  • [X] Code is as readable as possible.
  • [X] I have reviewed this PR myself, ensuring it meets each checklist item

EinfachHans avatar Jul 31 '24 07:07 EinfachHans