OneSignal-iOS-SDK
OneSignal-iOS-SDK copied to clipboard
WIP - Fix subscribing when Background Modes are off and Direct To History is enabled
Issue
If Background Modes are off under Xcode > Capabilities AND iOS "Enable iOS 12 Direct To History" is enabled on the OneSignal dashboard settings the player will be created with the following on the dashboard;"Provisioning Profile Missing Push Permission"
The SDK reports notification_types as 80 and no identifier.
Also calling OneSignal.promptForPushNotificationsWithUserResponse says that it is disabled when it isn't and won't show a prompt.
TODO
registerForAPNsTokenneeds to check fornotifPermissionState.provisional.
- Complete in commit 37a4d6f
- We need to delay calling
registerForAPNsTokenuntil the download params completes. - Write unit test reproducing issue
This PR is approved however incomplete so do not merge it yet!
Prompting for full push now works as intended but the dashboard still shows "Provisioning Profile Missing Push Permission". What should we be displaying if background push is off?