Change OSPushSubscriptionState's `"nil"` json values to be `""`

Open nan-li opened this issue 1 year ago • 0 comments

Description

Change OSPushSubscriptionState's json representation to have values of "" (empty string) instead of "nil" (a string literal of nil).

The dictionary representation would be better as empty strings instead of the string literal "nil".
This way, it is easier to check for the emptiness of these properties.
This method is likely consumed by wrappers and the "nil" value is passed along all this time?

Do we want to make this change? It simplifies wrapper consumption of this method but could be a breaking change if any developers are using this method directly and checking against "nil".
Affects dictionary representation

None

iPhone 13 on iOS 17.2

[ ] Notifications
- [ ] Display
- [ ] Open
- [ ] Push Processing
- [ ] Confirm Deliveries
[ ] Outcomes
[ ] Sessions
[ ] In-App Messaging
[ ] REST API requests
[ ] Public API changes

[ ] I have filled out all REQUIRED sections above
[ ] PR does one thing
- If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
[ ] Any Public API changes are explained in the PR details and conform to existing APIs

[ ] I have included test coverage for these changes, or explained why they are not needed
[ ] All automated tests pass, or I explained why that is not possible
[ ] I have personally tested this on my device, or explained why that is not possible

[ ] Code is as readable as possible.
- Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
[ ] I have reviewed this PR myself, ensuring it meets each checklist item
- WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is

Feb 15 '24 23:02 nan-li