OneSignal-iOS-SDK icon indicating copy to clipboard operation
OneSignal-iOS-SDK copied to clipboard

WiP Add OneSignalUser sub module to release process

Open emawby opened this issue 3 years ago • 0 comments

WiP

This PR is based off of a WiP commit that created the OneSignalUser module. I am using this PR to test including a swift based framework in the OneSignal XCFramework when distributed via SwiftPM and Cocoapods

Description

One Line Summary

Adds the OneSiganlUser module to build scripts and package managers.

Details

  • Updated build_all_frameworks.sh to include the OneSignalUser Framework. In order for this archive to succeed I needed to set build for distribution to true in the Xcode project build settings.
  • Removed unused build scripts.
  • Update update_swift_packages.sh to create a zip of the OneSignalUser XCFramework and update the Package.swift as appropriate
  • Add a OneSignalUser sub module to both of our podspecs
  • Add a OneSignalUser target and binary target to the Package.swift which is depended on by the OneSignal target
  • Create a OneSignalUser folder with dummy files for Swift PM

Motivation

This is required to release version 5.0.0

Scope

Release process

Testing

Manual testing

I tested the archives and scripts

Affected code checklist

  • [ ] Notifications
    • [ ] Display
    • [ ] Open
    • [ ] Push Processing
    • [ ] Confirm Deliveries
  • [ ] Outcomes
  • [ ] Sessions
  • [ ] In-App Messaging
  • [ ] REST API requests
  • [ ] Public API changes
  • [x] Release Process

Checklist

Overview

  • [x] I have filled out all REQUIRED sections above
  • [x] PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • [x] Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • [x] I have included test coverage for these changes, or explained why they are not needed
  • [x] All automated tests pass, or I explained why that is not possible
  • [x] I have personally tested this on my device, or explained why that is not possible

I successfully tested SwiftPM by attaching the zipped binaries to a release and referencing the branch. It compiled, ran, and archived successfully

Final pass

  • [x] Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • [x] I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

emawby avatar Jul 05 '22 18:07 emawby