OneSignal-Website-SDK icon indicating copy to clipboard operation
OneSignal-Website-SDK copied to clipboard

[Bug]: Identity Verification is fully broken for all users

Open bmulholland opened this issue 2 years ago • 9 comments

What happened?

getJWTHeader literally isn't called anywhere. Just search the repo. That's the only place that sets the Authorization header required by Identity Verification.

so Identity Verification is not supported by this library. At all!

Shouldn't tests cover that or something? Why am I debugging mission-critical parts of this SDK?

What browsers are you seeing the problem on?

Firefox, Chrome (Chromium)

What operating system are you running?

Steps to reproduce?

turn on identity verification

note that identity calls fail now

look at code and see that there is no code path that calls getJWTHeader

What did you expect to happen?

Relevant log output

No response

bmulholland avatar Aug 18 '23 16:08 bmulholland

@bmulholland Thanks for reporting.

Identity Verification id not available yet with our just released User Model APIs. Sorry we did not make this clear in our release notes and documentation, we are correcting that.

Adding Identity Verification support is one of the top things we are working since introducing User Model. However you may use our older SDK and APIs until we have support. See our v9.0 documentation for the Player Model APIs: https://documentation.onesignal.com/v9.0/docs/identity-verification

jkasten2 avatar Aug 18 '23 17:08 jkasten2

Okay but then the code should also detect this scenario and throw an appropriate error. There’s standard things to be done to make these things reasonable for the users of the software.

I spent my entire day today essentially QAing and beta testing this release without even being clear I was opting in to that. The code is broken and the docs are a mix of old and new, broken all over. Support never even responded. Incredibly frustrating.

bmulholland avatar Aug 18 '23 18:08 bmulholland

Honestly... Why the heck are you guys even releasing a new Major version when you KNOW it's broken? What's the point here? Why not release it as alpha/beta?

I tried updating cause I kind of need the foregroundWillDisplay event but it's blowing up left and right. (Been spamming all my errors into the https://github.com/OneSignal/react-onesignal repo)

The current state of this is practically not usable at all.

KDederichs avatar Aug 23 '23 13:08 KDederichs