OneSignal-Unity-SDK
OneSignal-Unity-SDK copied to clipboard
Added #ifdef UNITY_IOS
A quick fix for issue #508.
Added #ifdef UNITY_IOS for the two build files in the IOS project so that a CI builder like game.ci can build Android in environments without the iOS modules.
I need this PR :)
Is there a deadline to apply this PR?
No, but we use game.ci build scheme, and android builds crashes, so we need to use another build machine.
Well, I can't assign reviewers. @gdeglin ?
com.onesignal.unity.ios/Editor/BuildPostProcessor.cs line 1 at r1 (raw file):
#if UNITY_IOS
Just a nit but, could you place this line after the “Modified MIT License” and “Testing Notes”?
com.onesignal.unity.ios/Editor/PBXProjectExtensions.cs line 1 at r1 (raw file):
#if UNITY_IOS
Another nit, could you place this line after the MIT License?
Thanks for making a PR.
Could you also open this against the develop branch instead and update the CHANGELOG with your change?
CHANGELOG.md Example:
## [Unreleased]
### [Fixed]
- <Your change>
#556 This PR can be closed now