OneSignal-Unity-SDK icon indicating copy to clipboard operation
OneSignal-Unity-SDK copied to clipboard

Added #ifdef UNITY_IOS

Open wmcburnett-HB opened this issue 3 years ago • 1 comments

A quick fix for issue #508.

Added #ifdef UNITY_IOS for the two build files in the IOS project so that a CI builder like game.ci can build Android in environments without the iOS modules.


This change is Reviewable

wmcburnett-HB avatar Aug 24 '22 21:08 wmcburnett-HB

I need this PR :)

Bald1nh0 avatar Sep 15 '22 16:09 Bald1nh0

Is there a deadline to apply this PR?

episuarez avatar Oct 13 '22 16:10 episuarez

No, but we use game.ci build scheme, and android builds crashes, so we need to use another build machine.

Bald1nh0 avatar Oct 14 '22 07:10 Bald1nh0

Well, I can't assign reviewers. @gdeglin ?

wmcburnett-HB avatar Oct 14 '22 14:10 wmcburnett-HB

com.onesignal.unity.ios/Editor/BuildPostProcessor.cs line 1 at r1 (raw file):

#if UNITY_IOS

Just a nit but, could you place this line after the “Modified MIT License” and “Testing Notes”?

shepherd-l avatar Nov 07 '22 22:11 shepherd-l

com.onesignal.unity.ios/Editor/PBXProjectExtensions.cs line 1 at r1 (raw file):

#if UNITY_IOS

Another nit, could you place this line after the MIT License?

shepherd-l avatar Nov 07 '22 22:11 shepherd-l

Thanks for making a PR. Could you also open this against the develop branch instead and update the CHANGELOG with your change?

CHANGELOG.md Example:

## [Unreleased]
### [Fixed]

- <Your change>

shepherd-l avatar Nov 07 '22 22:11 shepherd-l

#556 This PR can be closed now

stopiccot avatar Nov 17 '22 11:11 stopiccot

Added this in the 3.0.6 release with #556

shepherd-l avatar Nov 18 '22 16:11 shepherd-l