OneSignal-Flutter-SDK icon indicating copy to clipboard operation
OneSignal-Flutter-SDK copied to clipboard

[BUG]: lint warning regarding PluginRegistry Depreciation

Open christopherowen opened this issue 2 years ago • 0 comments
trafficstars

What happened?

I'm receiving this error on release build with lint enabled:

/opt/homebrew/Caskroom/flutter/3.7.0/flutter/.pub-cache/hosted/pub.dev/onesignal_flutter-3.5.0/android/src/main/java/com/onesignal/flutter/OneSignalOutcomeEventsController.java:15: warning: [deprecation] Registrar in PluginRegistry has been deprecated
import io.flutter.plugin.common.PluginRegistry.Registrar;
                                              ^
/opt/homebrew/Caskroom/flutter/3.7.0/flutter/.pub-cache/hosted/pub.dev/onesignal_flutter-3.5.0/android/src/main/java/com/onesignal/flutter/OneSignalPlugin.java:42: warning: [deprecation] Registrar in PluginRegistry has been deprecated
import io.flutter.plugin.common.PluginRegistry.Registrar;
                                              ^
/opt/homebrew/Caskroom/flutter/3.7.0/flutter/.pub-cache/hosted/pub.dev/onesignal_flutter-3.5.0/android/src/main/java/com/onesignal/flutter/OneSignalPlugin.java:43: warning: [deprecation] FlutterNativeView in io.flutter.view has been deprecated
import io.flutter.view.FlutterNativeView;
                      ^
/opt/homebrew/Caskroom/flutter/3.7.0/flutter/.pub-cache/hosted/pub.dev/onesignal_flutter-3.5.0/android/src/main/java/com/onesignal/flutter/OneSignalTagsController.java:20: warning: [deprecation] Registrar in PluginRegistry has been deprecated
import io.flutter.plugin.common.PluginRegistry.Registrar;
                                              ^
/opt/homebrew/Caskroom/flutter/3.7.0/flutter/.pub-cache/hosted/pub.dev/onesignal_flutter-3.5.0/android/src/main/java/com/onesignal/flutter/OneSignalInAppMessagingController.java:13: warning: [deprecation] Registrar in PluginRegistry has been deprecated
import io.flutter.plugin.common.PluginRegistry.Registrar;
                                              ^
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

Steps to reproduce?

1. build a flutter project using onesignal with lint enabled

What did you expect to happen?

No lint warnings.

My searching on the topic lead me to this page, but I'm a little out of my depth:

https://api.flutter.dev/javadoc/io/flutter/plugin/common/PluginRegistry.html https://docs.flutter.dev/development/platform-integration/android/plugin-api-migration

OneSignal Flutter SDK version

Release 3.5.0

Which platform(s) are affected?

  • [ ] iOS
  • [X] Android

Relevant log output

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

christopherowen avatar Jan 30 '23 15:01 christopherowen