onebusaway-android
onebusaway-android copied to clipboard
Fix #661: Append HTTPS to URLs without Protocol
When typing in a URL without a protocol (http://, https://, ftp://) for custom API URLs, auto-prepend https in front to fix Issue #661.
- Successfully able to enter maps.usf.edu/otp without prefix then plan a trip in Tampa, tested in Nexus 5 emu.
- gradlew connectedObaGoogleDebugAndroidTest connectedObaAmazonDebugAndroidTest: Success.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
azizmb9494 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
Thanks @azizmb9494! I'll try to review this soon. IIRC we have other URL clean-up code for the OBA API, so that might need to change back to how it is in the master branch.
closing due to need for CLA signing and merge conflicts. please reopen with those issues resolved if you can! I'd love to land this PR!