onebusaway-android icon indicating copy to clipboard operation
onebusaway-android copied to clipboard

Fixed #837 - Added margin in route_list_item.xml and stop_list_item.x…

Open GajananPalepwad opened this issue 1 year ago • 3 comments

…ml to align with the header title

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [x] Apply the AndroidStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

GajananPalepwad avatar Mar 08 '24 08:03 GajananPalepwad

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 08 '24 08:03 CLAassistant

@aaronbrethorst plz check this i have redid the pr

GajananPalepwad avatar Mar 08 '24 08:03 GajananPalepwad

image i have signed but its showing not signed

GajananPalepwad avatar Mar 08 '24 08:03 GajananPalepwad

@GajananPalepwad thank you for tackling this and submitting a pull request. After reviewing where Android is today in terms of UI design, I think it actually makes more sense for us to close the original ticket as 'not planned,' instead of incorporating it into the product. Apologies for having you spend your time on this, but I appreciate the dedication. Please feel free to reach out to me before tackling something else in case this happens again.

aaronbrethorst avatar Mar 11 '24 00:03 aaronbrethorst

@GajananPalepwad thank you for tackling this and submitting a pull request. After reviewing where Android is today in terms of UI design, I think it actually makes more sense for us to close the original ticket as 'not planned,' instead of incorporating it into the product. Apologies for having you spend your time on this, but I appreciate the dedication. Please feel free to reach out to me before tackling something else in case this happens again.

Ok sir no problem

GajananPalepwad avatar Mar 11 '24 03:03 GajananPalepwad