csharp-language-server-protocol icon indicating copy to clipboard operation
csharp-language-server-protocol copied to clipboard

Fix rocket.surgery.nuke Update

Open JoeRobich opened this issue 10 months ago • 7 comments

Fix up #1336

  • Mimic the style of the RSG/Nuke repo's .build
  • Regenerated GH actions
  • Left in the tweaks around NuGet caching, the matrix of artifacts, and NuGet publishing

JoeRobich avatar Feb 04 '25 06:02 JoeRobich

Test Results

0 tests   0 ✅  0s ⏱️ 0 suites  0 💤 0 files    0 ❌

Results for commit a7202f76.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Feb 04 '25 07:02 github-actions[bot]

Reviewing the CI logs it appears to be having trouble locating the test results and code coverage. Need to investigate further.

JoeRobich avatar Feb 04 '25 20:02 JoeRobich

I have found a possible explanation inside build logs:

[INF] "/home/runner/work/csharp-language-server-protocol/csharp-language-server-protocol/test/coverlet.runsettings" is not a valid Coverage settings file. Using default values.

But I do not see which part is considered as invalid.

manandre avatar Feb 08 '25 18:02 manandre

Solution found! The DataCollector must be named code coverage and not XPlat code coverage.

manandre avatar Feb 08 '25 20:02 manandre

Summary

Summary
Generated on: 2/9/2025 - 12:00:39 AM
Coverage date: 2/9/2025 - 12:00:38 AM
Parser: Cobertura
Assemblies: 0
Classes: 0
Files: 0
Line coverage:
Covered lines: 0
Uncovered lines: 0
Coverable lines: 0
Total lines: 0
Covered branches: 0
Total branches: 0
Method coverage: Feature is only available for sponsors
Tag: 0.19.10-PullRequest1449.510+Branch.pull-1449-merge.Sha.a9a325e63b093e7c42512271baf5ffc751041f01

Coverage

No assemblies have been covered.

github-actions[bot] avatar Feb 09 '25 00:02 github-actions[bot]

Maybe it doesn't like the relative paths image from the logs

2025-02-08T23:58:55.7518600Z [INF] Starting test execution, please wait...
2025-02-08T23:58:55.8026940Z [INF] A total of 1 test files matched the specified pattern.
2025-02-08T23:58:56.1031980Z [INF] [xUnit.net 00:00:01.37]     JsonRpc.Tests.HandlerResolverTests.Should_Have_CorrectParams [SKIP]
2025-02-08T23:58:56.1063840Z [INF] [xUnit.net 00:00:01.37]     JsonRpc.Tests.HandlerResolverTests.Should_Contain_AllDefinedMethods [SKIP]
2025-02-08T23:58:56.1270350Z [INF]   Skipped JsonRpc.Tests.HandlerResolverTests.Should_Have_CorrectParams [1 ms]
2025-02-08T23:58:56.1385180Z [INF]   Skipped JsonRpc.Tests.HandlerResolverTests.Should_Contain_AllDefinedMethods [1 ms]
2025-02-08T23:58:58.4653570Z [INF] Results File: /Users/runner/work/csharp-language-server-protocol/csharp-language-server-protocol/artifacts/test/_Mac-1739056916847_2025-02-08_23_58_57.trx
2025-02-08T23:58:58.4761190Z [INF] 
2025-02-08T23:58:58.4863110Z [INF] Passed!  - Failed:     0, Passed:     8, Skipped:     0, Total:     8, Duration: 1 s - OmniSharp.Extensions.LanguageClient.Tests.dll (net8.0)
2025-02-08T23:58:58.4925490Z [INF]   [coverlet] 
2025-02-08T23:58:58.5026360Z [INF]   Calculating coverage result...
2025-02-08T23:58:58.5384890Z [INF]    Generating report '/Users/runner/work/csharp-language-server-protocol/csharp-language-server-protocol/test/coverage/Client-Tests/coverage.net8.0.json'
2025-02-08T23:58:58.5408980Z [INF]    Generating report '/Users/runner/work/csharp-language-server-protocol/csharp-language-server-protocol/test/coverage/Client-Tests/coverage.net8.0.info'
2025-02-08T23:58:58.5421430Z [INF]    Generating report '/Users/runner/work/csharp-language-server-protocol/csharp-language-server-protocol/test/coverage/Client-Tests/coverage.net8.0.cobertura.xml'
2025-02-08T23:58:58.5474940Z [INF]    Generating report '/Users/runner/work/csharp-language-server-protocol/csharp-language-server-protocol/test/coverage/Client-Tests/coverage.net8.0.opencover.xml'

JoeRobich avatar Feb 09 '25 00:02 JoeRobich

Surprising. The previous step is also using a relative path artifacts/logs/ and seems to work correctly.

manandre avatar Feb 09 '25 21:02 manandre