charon icon indicating copy to clipboard operation
charon copied to clipboard

refactor: use slices.Contains to simplify code

Open hardlydearly opened this issue 6 months ago • 2 comments

There is a new function added in the go1.21 standard library, which can make the code more concise and easy to read.

hardlydearly avatar Apr 30 '25 04:04 hardlydearly

@hardlydearly can you format your PR description, according to the guidelines?

KaloyanTanev avatar Apr 30 '25 10:04 KaloyanTanev

@hardlydearly can you format your PR description, according to the guidelines?

Done. Please review again.

hardlydearly avatar May 02 '25 13:05 hardlydearly

@hardlydearly Please read the contributing.md doc here.

KaloyanTanev avatar May 02 '25 15:05 KaloyanTanev

@hardlydearly Please read the contributing.md doc here.

And also this section: https://github.com/ObolNetwork/charon/blob/main/docs/contributing.md#chore-prs

pinebit avatar May 05 '25 13:05 pinebit

@hardlydearly Please read the contributing.md doc here.

And also this section: https://github.com/ObolNetwork/charon/blob/main/docs/contributing.md#chore-prs

Thanks. Modified. Please review again.

hardlydearly avatar May 08 '25 14:05 hardlydearly

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.67%. Comparing base (0246897) to head (71bc5e9). Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3668      +/-   ##
==========================================
- Coverage   53.72%   53.67%   -0.05%     
==========================================
  Files         223      223              
  Lines       35379    35379              
==========================================
- Hits        19008    18991      -17     
- Misses      14264    14283      +19     
+ Partials     2107     2105       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 08 '25 20:05 codecov[bot]