NodeGoat icon indicating copy to clipboard operation
NodeGoat copied to clipboard

Add lint workflow

Open rcowsill opened this issue 4 years ago • 2 comments
trafficstars

This adds a lint workflow and fixes the jshint errors so the workflow succeeds. Most of the changes were for doublequote/semicolon use and missing "use strict" directives.

~~(WIP: still need to fix the last four "line too long" errors)~~

rcowsill avatar Jan 28 '21 01:01 rcowsill

This is good to go now.

I'd still like to confirm that the changes to test_profile.js haven't broken anything, but I'm having trouble with the selenium/ZAP setup. I've left a message on OWASP gitter about it; any help would be much appreciated.

rcowsill avatar Jan 29 '21 12:01 rcowsill

@binarymist can you please have a look at this PR and confirm that changes to test_profile.js doesn't break selenium/ZAP tests. Thanks!

ckarande avatar Feb 07 '21 13:02 ckarande