redis-operator icon indicating copy to clipboard operation
redis-operator copied to clipboard

Remove latest version for conversion webhook

Open MathieuCesbron opened this issue 1 year ago • 4 comments

Description

The point of the conversion webhook is too update some v1beta1 fields basically and it does nothing for v1beta2. I removed the conversion webhook for v1beta2 version because there is no need to call the conversion for them.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • [x] Tests have been added/modified and all tests pass.
  • [x] Functionality/bugs have been confirmed to be unchanged or fixed.
  • [x] I have performed a self-review of my own code.
  • [x] Documentation has been updated or added where necessary.

MathieuCesbron avatar Jan 25 '24 17:01 MathieuCesbron

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3e6fcb9) 32.79% compared to head (bbb43fc) 32.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #760   +/-   ##
=======================================
  Coverage   32.79%   32.79%           
=======================================
  Files          19       19           
  Lines        3232     3232           
=======================================
  Hits         1060     1060           
  Misses       2113     2113           
  Partials       59       59           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 25 '24 17:01 codecov[bot]

Some people may still use v1beta1. IMO, we still need conversion in a period of time.

drivebyer avatar Jan 26 '24 02:01 drivebyer

Thanks for the comment. Yes, I agree we should only trigger the conversion for v1beta1 version and not for v1beta2 because it’s gonna convert nothing.

That’s why I removed it from the selector. Am I missing something ?

MathieuCesbron avatar Jan 26 '24 02:01 MathieuCesbron

I'm not familiar with the conversionReviewVersions mechanism; maybe need help.@shubham-cmyk

drivebyer avatar Jan 26 '24 07:01 drivebyer