OSVR-Core icon indicating copy to clipboard operation
OSVR-Core copied to clipboard

Published 20 hours ago • verified publisher icon OSVR

Gesture interface merge

Open gfrolov opened this issue 10 years ago • 7 comments

gfrolov avatar Jul 20 '15 15:07 gfrolov

Notes about Leap Motion gestures: https://github.com/OSVR/OSVR-Leap-Motion/issues/5

zachkinstner avatar Aug 18 '15 12:08 zachkinstner

The places where an Interface pointer is being held, should instead be using an InternalInterfaceOwner, which was just added to master recently.

rpavlik avatar Aug 18 '15 16:08 rpavlik

This pull request is ready to be merged

gfrolov avatar Sep 09 '15 14:09 gfrolov

OK - blocked on #218 - after that is finished (unit tests) and merged, this can be rebased on top of the new master. Most of all the "little" pieces that are independent have been pulled out and merged separately, so there will be ample use of git mergetool during that rebase, but it should result in a more digestable diff. I'd also suggest squashing related commits down into a single commit, especially early in the history where a lot of things changed since then.

rpavlik avatar Sep 21 '15 22:09 rpavlik

I completed unit tests merged #218 yesterday and rebased gesture branch on top of master. Also I fixed a few things that wouldn't let it build and some compiler errors.

gfrolov avatar Sep 23 '15 18:09 gfrolov

Will require fix to adjust for https://github.com/OSVR/OSVR-Core/commit/0a63fd5e091b4b615607f6ddde78acb6f2d49f2d once that branch is merged. Sorry...

rpavlik avatar Nov 11 '15 18:11 rpavlik

If this adds any additional typesafeids beyond those in stringids already in master, those will need to be adjusted for https://github.com/OSVR/OSVR-Core/commit/477c662c5ee093d4d139e5ffe18eabfa27f3fafb

rpavlik avatar Feb 05 '16 21:02 rpavlik