osmcha-frontend icon indicating copy to clipboard operation
osmcha-frontend copied to clipboard

Enable using location search with shorter place names

Open lliehu opened this issue 2 years ago • 2 comments

This is the first attempt at fixing problems with location search when Chinese or other similar languages are used. Please see commit messages for details.

Related issue is: https://github.com/mapbox/osmcha-frontend/issues/538

Tested manually on both Firefox and Brave. It looks like the used select component has more strange issues. Was not able to fix those but also checked that I didn't create more issues. The react-select version is quite old: ^1.0.0-rc.5 in package.json while latest release is 5.7.3.

lliehu avatar Jun 24 '23 19:06 lliehu

@willemarcel Could I request your review on this?

GitHub doesn't allow me to add any reviewers to this PR. I hope you forgive this ping after weeks of waiting and not understanding how to better request a review from someone in this project.

lliehu avatar Aug 14 '23 23:08 lliehu

@lliehu sorry for the delay and thanks for the PR. I'll review it this week.

willemarcel avatar Aug 23 '23 00:08 willemarcel