osmcha-frontend icon indicating copy to clipboard operation
osmcha-frontend copied to clipboard

Tag changes applied after creating but in a second OSM-file are not shown

Open pietervdvn opened this issue 2 years ago • 0 comments

I'm submitting a bug report/feature request

Brief Description

When an object is created in one call to the API and then changed in the same changeset with a second call, then not all tag_changes are found.

What is the current behaviour, (attach relevant screenshots) ?

An example of such changeset is this one (OsmCha):

  1. The changeset was opened
  2. First, the node was created and uploaded
  3. A link to an image was added in a second api call, bumping the version number of the node to 2
  4. The changeset was closed by timeout.

The OsmCha api reports the following properties for this changeset, where image= is missing from tag_changes :

 {
        "check_user": null,
        "reasons": [
          {
            "id": 40,
            "name": "New mapper"
          }
        ],
        "tags": [],
        "features": [],
        "user": "Vasilisvg",
        "uid": "555971",
        "editor": "MapComplete 0.25.4",
        "comment": "Adding data with #MapComplete for theme #bookcases",
        "comments_count": 0,
        "source": "Not reported",
        "imagery_used": "Not reported",
        "date": "2023-01-13T10:29:47Z",
        "reviewed_features": [],
        "tag_changes": {
          "amenity": [
            "public_bookcase"
          ]
        },
        "create": 1,
        "modify": 1,
        "delete": 0,
        "area": 0,
        "is_suspect": true,
        "harmful": null,
        "checked": false,
        "check_date": null,
        "host": "https://mapcomplete.osm.be/bookcases",
        "theme": "bookcases",
        "locale": "en",
        "imagery": "osm",
        "add-image": 1,
        "id": 131223333
      }

What is the expected behaviour ?

tag_changes contains both amenity=public_bookcase and image=<link>

When does this occur ?

See above

What is the motivation / use case for this feature?

My Mastodon-bot couldn't find some of the images ;)

How do we replicate the issue ?

See links above

Please tell us about your environment:

API-call + browser (but not relevant)

pietervdvn avatar Jan 14 '23 17:01 pietervdvn