osmcha-frontend icon indicating copy to clipboard operation
osmcha-frontend copied to clipboard

Check for non-square buildings

Open aawiseman opened this issue 7 years ago • 4 comments

I'm submitting a feature request

Brief Description

A flag for buildings that have corners that aren’t 90 degrees

aawiseman avatar Apr 03 '18 16:04 aawiseman

We are using the relying on the iD validation.

willemarcel avatar Sep 18 '20 14:09 willemarcel

These changesets are containing a lot of unsquared buildings. It will be great if OSMCha has ways to detect this sort of behaviour.

image

adiatmad avatar Aug 22 '22 13:08 adiatmad

In addition to the previous: maybe an OSMCha flag that would detect when square buildings are edited in such a way that their squareness would be lost.

martien-176 avatar Aug 22 '22 15:08 martien-176

This would need to be added as a Compare function in the osm-compare repository: https://github.com/mapbox/osm-compare

One can look at the comparators in https://github.com/mapbox/osm-compare/tree/master/comparators and make a new one to detect this kind of geometry change.

I made an issue on the osm-compare repository referencing this issue: https://github.com/mapbox/osm-compare/issues/230

We should close this issue and follow up in the osm-compare repository / it would be great if someone is able to take a first stab at this.

batpad avatar Aug 22 '22 17:08 batpad