grass icon indicating copy to clipboard operation
grass copied to clipboard

i.ortho.init: fix use flag bug

Open jayneel-shah18 opened this issue 6 months ago • 2 comments

This PR fixes a logic bug in the i.ortho.init module, it caused incorrect persistence and reporting of the use flag, even when the -r flag was passed by the user.

Code change:

The use flag is updated only when -r is explicitly passed:

if (use_flag->answer) { init_info->status = 1; }

Tested Behaviour:

  • use=1 is set when -r is passed.
  • use remains unchanged when -r is omitted.
  • Values persist correctly across multiple runs.

This PR fixes https://github.com/OSGeo/grass/issues/5853.

jayneel-shah18 avatar Jun 11 '25 13:06 jayneel-shah18

This is not fixing anything, it will result in the same behavior. Since neither of us have a good understanding of the intended behavior, I suggest to leave it and remove it from the test.

petrasovaa avatar Jun 11 '25 18:06 petrasovaa

Understood, I will remove this from the tests so that we can merge them.

jayneel-shah18 avatar Jun 12 '25 13:06 jayneel-shah18