grass icon indicating copy to clipboard operation
grass copied to clipboard

t.rast.neighbors: support all r.neighbors features and allow to append to existing STRDS as well as filtering by region

Open ninsbl opened this issue 1 year ago • 2 comments

This PR:

  • propagates features (options and flags) from r.neighbors to t.rast.neighbors that were available in the underlying module, but not it's TGIS version
  • adds filtering by computational region
  • allows to append results to an existing STRDS
  • reactivates and extends the tests

We may remove the SHELL version of the tests...

ninsbl avatar Jun 11 '24 22:06 ninsbl

See also #3427

ninsbl avatar Jun 12 '24 07:06 ninsbl

The manual is now also updated with the changes in this PR.

ninsbl avatar Jun 15 '24 20:06 ninsbl

The fix in 4e6f5bf should probably be backported to 8.4...

ninsbl avatar Jul 14 '24 11:07 ninsbl

The fix in 4e6f5bf should probably be backported to 8.4...

Should this still go into 8.4.0 or 8.4.1?

neteler avatar Jul 14 '24 16:07 neteler

The fix in 4e6f5bf should probably be backported to 8.4...

Should this still go into 8.4.0 or 8.4.1?

I think 8.4.1 can be sufficient as it does not seem to cause issues other places in main. Not sure about addons though... I can do a quick backport 8.4.0 if that is preferable...

ninsbl avatar Jul 16 '24 07:07 ninsbl

@ninsbl I think it's ready, but just before, can you try (locally) if with ruff 0.5.3 there's no changes (PLR17xx something changed and covers a new case than before). I don't think it's worth a full new run of CI, but just check again, it takes less than a second to run ;)

echoix avatar Jul 19 '24 02:07 echoix

No changes with ruff 0.5.3 detected...

ninsbl avatar Jul 19 '24 06:07 ninsbl