grass
grass copied to clipboard
t.rast.neighbors: support all r.neighbors features and allow to append to existing STRDS as well as filtering by region
This PR:
- propagates features (options and flags) from r.neighbors to t.rast.neighbors that were available in the underlying module, but not it's TGIS version
- adds filtering by computational region
- allows to append results to an existing STRDS
- reactivates and extends the tests
We may remove the SHELL version of the tests...
See also #3427
The manual is now also updated with the changes in this PR.
The fix in 4e6f5bf should probably be backported to 8.4...
The fix in 4e6f5bf should probably be backported to 8.4...
Should this still go into 8.4.0 or 8.4.1?
The fix in 4e6f5bf should probably be backported to 8.4...
Should this still go into 8.4.0 or 8.4.1?
I think 8.4.1 can be sufficient as it does not seem to cause issues other places in main. Not sure about addons though... I can do a quick backport 8.4.0 if that is preferable...
@ninsbl I think it's ready, but just before, can you try (locally) if with ruff 0.5.3 there's no changes (PLR17xx something changed and covers a new case than before). I don't think it's worth a full new run of CI, but just check again, it takes less than a second to run ;)
No changes with ruff 0.5.3 detected...