grass
grass copied to clipboard
Should the list of possible arguments passed to `Popen` from our `Popen` wrapper be kept updated with Python releases?
I'm launching a small discussion here, as I was attentively passing through some code paths.
Should the list of possible arguments passed to Popen from our Popen wrapper be kept updated with Python releases?
Like in this file:
https://github.com/OSGeo/grass/blob/53c362dbd118f67a0dd7cbf00a0e6f967eae1b58/python/grass/script/core.py#L77-L91
Valid keyword arguments change from version to version, and some are added. What was that filtering made to protect? Is there a way that using a newer valid keyword that was supposed to be passed to Popen, but isn't, could be a problem? (Problem: either from our side, or from Python's side, or even security-wise)
Keywords and changes are indicated throughout https://docs.python.org/3/library/subprocess.html