grass icon indicating copy to clipboard operation
grass copied to clipboard

Set up rules for managing PRs

Open landam opened this issue 2 years ago • 1 comments

Currently we have a large number of open PR which are in different shape (approved, commented, change requested, no feedback).

image

Let's improve this situation by setting up rules, which help us to manage PRs. See few points below to open discussion:

  • no changes requested from reviewers + tests passed -> PR will be merged by assignee
  • every PR must have assignee who is responsible for merging or closing
    • PRs reported by member with write access will be automatically assigned to reporter
    • PRs reported by member without write access will be assigned based on topic / first label (assignee may be reassigned (no time, limited expertise) to someone else)

landam avatar Nov 10 '23 16:11 landam

I'm glad this issue is up to discussion. As a committer I have (too often) experienced what is really sticking out in the statistics you provide: "No feedback" – ending up more often than not to put up an "ultimatum" ("If there are no objections....") to move things forward. That I only do, however, when I have absolutely no doubts myself on the PR in question, but I'd prefer to have some level of feedback. I'm quite certain that this situation – in general – is not a sign of lack of enthusiasm, but of time available to dedicate to this project.

nilason avatar Nov 21 '23 09:11 nilason