grass icon indicating copy to clipboard operation
grass copied to clipboard

[Bug] wxGUI/nviz: tabs/pages with foldpanels are broken on Mac

Open nilason opened this issue 2 years ago • 0 comments

Describe the bug The #3089 which aimed to make 3D View configuration panels scrollable, succeeded also for Mac for the View and the Animation panel. The Data, Appearance and the Analysis panels remain however quite unusable.

The broken panels, all containing foldpanels, do not add scrollbars if needed. Selecting one of them issues the following log message:

Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.10/l
ib/python3.10/site-packages/wx/core.py", line 2346, in
Notify

self.notify()
  File "/Library/Frameworks/Python.framework/Versions/3.10/l
ib/python3.10/site-packages/wx/core.py", line 3552, in
Notify

self.result = self.callable(*self.args, **self.kwargs)
  File "/dev/grass/dist.aarch64-apple-
darwin22.6.0/gui/wxpython/nviz/tools.py", line 237, in
UpdateScrolling

length = foldpanel.GetPanelsLength(collapsed=0, expanded=0)
AttributeError
:
'ScrollBar' object has no attribute 'GetPanelsLength'

which indicates object hierarchy deviation for macOS compared to other systems.

Perhaps related to this hierarchy issue, is the circumstance that the collapsing/expanding of the foldpanelbars is not working as expected (see screenshot below).

Expected behavior The 3D view panels should be scrollable if needed and expanding/collapsing of foldpanelbars should work cleanly.

Screenshots

wxgui_nviz_mac

System description

  • Operating System: macOS
  • GRASS GIS version: 8.3, 8.4.0dev
version=8.4.0dev
date=2023
revision=66be58a708
build_date=2023-11-07
build_platform=aarch64-apple-darwin22.6.0
build_off_t_size=8
libgis_revision=70ecf8ec0b
libgis_date=2023-11-07T09:23:56+00:00
proj=9.3.0
gdal=3.7.3
geos=3.12.0
sqlite=3.44.0
Python 3.10.10 (v3.10.10:aad5f6a891, Feb  7 2023, 08:47:40) [Clang 13.0.0 (clang-1300.0.29.30)]
wxPython 4.2.0 osx-cocoa (phoenix) wxWidgets 3.2.0

nilason avatar Nov 08 '23 09:11 nilason