grass icon indicating copy to clipboard operation
grass copied to clipboard

v.db.connect: Replace -o flag with the standard --overwrite

Open HuidaeCho opened this issue 2 years ago • 4 comments

This PR fixes #3149 by using the standard --overwrite flag.

HuidaeCho avatar Oct 22 '23 12:10 HuidaeCho

I'm sorry, but this shall not pass. You should not remove a flag in non-major release. Please add a printf with warning whenever -o is used: "The -o flag is deprecated and will be removed in future releases. Use --o instead" To future proof the code, wrap the old -o in a macro #if GRASS_VERSION_MAJOR < 9

marisn avatar Oct 22 '23 20:10 marisn

This PR requires #3256.

HuidaeCho avatar Nov 22 '23 04:11 HuidaeCho

@marisn, @landam Will this work with #3256?

HuidaeCho avatar Nov 22 '23 04:11 HuidaeCho

@marisn, @landam Will this work with #3256?

Yes. I tested together with #3256 and backwards compatibility is in place.

marisn avatar Dec 03 '23 09:12 marisn

@HuidaeCho Please feel free to merge (you have more than zero approvals)...

landam avatar Mar 22 '24 23:03 landam