grass icon indicating copy to clipboard operation
grass copied to clipboard

r.surf.gauss: Added seed option and flag

Open cwhite911 opened this issue 2 years ago • 1 comments

Addresses issue https://github.com/OSGeo/grass/issues/1044 to add seed parameter and flag for reproducible results to the r.surf.gauss module. However, tests are currently not present and should still be included.

cwhite911 avatar Apr 21 '23 21:04 cwhite911

I know this is a draft, but just to be clear, the compilation fails for raster/r.surf.gauss.

wenzeslaus avatar Apr 22 '23 20:04 wenzeslaus

@petrasovaa I updated the tests to check the univar stats are correct,

cwhite911 avatar Mar 21 '24 18:03 cwhite911

The Labeler went nearly all-in for this. @echoix Do you perhaps know why?

nilason avatar Mar 21 '24 18:03 nilason

I think it's because it was an old PR, and merging main in it meant a lot of changes in everywhere. But I'm not sure. Now we don't remove labels automatically, so a next commit should only use the ones that are defined.

If it is still unexpected, maybe a rebase would do the trick...

echoix avatar Mar 21 '24 19:03 echoix

...merging main in it meant a lot of changes in everywhere....

That sounds plausible.

nilason avatar Mar 21 '24 19:03 nilason

...merging main in it meant a lot of changes in everywhere....

That sounds plausible.

It doesn't worry that me that much.

echoix avatar Mar 21 '24 20:03 echoix

@cwhite911 see the discussion we had in https://github.com/OSGeo/grass/pull/3480#discussion_r1519351514, we basically decided not to use the -s flag, so this PR needs to be updated...

petrasovaa avatar Mar 22 '24 14:03 petrasovaa

...merging main in it meant a lot of changes in everywhere....

That sounds plausible.

It doesn't worry that me that much.

This might of been my fault. When was catching this project up I rebased and had to go back and fix the branch by resetting it to your commit then cherry-picking the work I just did.

cwhite911 avatar Mar 22 '24 21:03 cwhite911