grass icon indicating copy to clipboard operation
grass copied to clipboard

configure: update to autoconf 2.71

Open nilason opened this issue 3 years ago • 3 comments
trafficstars

Update GRASS configure to autoconf 2.71 (from present 2.69).

From autoconf 2.70 announcement:

We are pleased to announce stable release 2.70 of GNU Autoconf.

This release includes eight years of development work since the previous release, 2.69. Noteworthy changes include support for the 2011 revisions of the C and C++ standards, support for reproducible builds, improved support for cross-compilation, improved compatibility with current compilers and shell utilities, more efficient generated shell code, and many bug fixes.

(see more)

Announcement of 2.71:

We are pleased to announce stable release 2.71 of Autoconf.

2.71 is a bugfix release, correcting several important compatibility problems and regressions discovered since the release of 2.70. There are no new features. Upgrading is recommended for all users of 2.70. Users of 2.69 or earlier should proceed with caution; please consult the NEWS file and/or the release announcement for 2.70 for details.

This is a smaller jump than the one from 2.13 to 2.69 (#1845), and (hopefully) avoids issues with patched distributions of autoconf, e.g. #2225 and #2280.

autoconf 2.71 News

nilason avatar Mar 26 '22 11:03 nilason

Current stable releases of e.g. Debian and Fedora come with autoconf 2.69. I suggest to wait with this PR until these two important Linux distros provide autoconf 2.71 in their latest stable releases.

metzm avatar Mar 27 '22 20:03 metzm

Current stable releases of e.g. Debian and Fedora come with autoconf 2.69. I suggest to wait with this PR until these two important Linux distros provide autoconf 2.71 in their latest stable releases.

This is not an urgent issue. I was foremost curious how much changes was needed to update and apparently there was not much. All the same, I tagged this to 8.4 and had no intention to suggest to backport it.

nilason avatar Mar 28 '22 09:03 nilason

Current stable releases of e.g. Debian and Fedora come with autoconf 2.69. I suggest to wait with this PR until these two important Linux distros provide autoconf 2.71 in their latest stable releases.

I just checked https://repology.org/project/autoconf/versions :

  • Debian 11 (bullseye - official): autoconf 2.69
  • Debian 12 (bookworm - in testing): autoconf 2.71
  • Fedora 36 (official): autoconf 2.71
  • Ubuntu 22.04 (testing): autoconf 2.69
  • Ubuntu 22.10 (testing): autoconf 2.71

neteler avatar Aug 28 '22 10:08 neteler

bookworm as been released

a-detiste avatar Aug 08 '23 22:08 a-detiste

@nilason Please can you rebase this PR?

landam avatar Nov 20 '23 18:11 landam

@nilason Please can you rebase this PR?

I will as soon as #2189 is merged. The two may conflict.

nilason avatar Dec 07 '23 19:12 nilason

@nilason Please can you rebase this PR?

I will as soon as #2189 is merged. The two may conflict.

#2189 is stuck as requires @wenzeslaus approval to get merged. I'll be mostly off starting from the next week thus (unless someone else merges it), no action till the new year.

marisn avatar Dec 08 '23 10:12 marisn

@nilason Please can you rebase this PR?

I will as soon as #2189 is merged. The two may conflict.

#2189 is stuck as requires @wenzeslaus approval to get merged. I'll be mostly off starting from the next week thus (unless someone else merges it), no action till the new year.

If it's okey with you, I'll go ahead with the rebase (and possibly merge if so agreed).

nilason avatar Dec 08 '23 10:12 nilason

If it's okey with you, I'll go ahead with the rebase (and possibly merge if so agreed).

Yes, feel free to do so. I'll manage with merging changes into #2189 (and, hopefully, one day be able to merge it too).

marisn avatar Dec 08 '23 11:12 marisn

Rebased. Looks good overall, but Travis' Clang build fails. Seems unrelated to me... clang --version fails due to missing clang, just before configure...

nilason avatar Dec 11 '23 18:12 nilason

Rebased. Looks good overall, but Travis' Clang build fails. Seems unrelated to me... clang --version fails due to missing clang, just before configure...

There is a new Travis docker build, created in Dec 7.

nilason avatar Dec 11 '23 19:12 nilason

Ahh, Travis is a good boy again.

nilason avatar Dec 11 '23 19:12 nilason

According to https://repology.org/project/autoconf/versions autoconf version 2.71 is the default on following systems:

  • Debian 12 'bookworm'
  • Fedora 36
  • Ubuntu 22.04 'jammy'

I believe the day has come to upgrade and merge this PR.

Note: autoconf (with this change, version 2.71) is only needed for (re-)generating the configure file, it is not needed for building. However, if there is any package system that regenerate the configure file as part of the building, it might cause problems, but I'm not aware of any such system.

Although the changes are small, it is preferable to merge this in good time before next release, to be able to test it properly.

nilason avatar Dec 12 '23 13:12 nilason

@metzm, @neteler, others: any objection to merge this?

nilason avatar Dec 22 '23 19:12 nilason

@nilason Please free to merge this PR (there are already three approvals)...

landam avatar Dec 22 '23 21:12 landam

I had maybe one last question, but it got merged when writing the question.

Where the changes in i.cluster/global.h intended in this PR (to fix something), or was a merge/rebase artifact? I didn't read a mention of it in this thread

echoix avatar Dec 22 '23 21:12 echoix

Where the changes in i.cluster/global.h intended in this PR (to fix something), or was a merge/rebase artifact? I didn't read a mention of it in this thread

It was intended, obsolete configure tests/macros with 2.71.

nilason avatar Dec 22 '23 21:12 nilason

Perfect then!

echoix avatar Dec 22 '23 21:12 echoix