grass icon indicating copy to clipboard operation
grass copied to clipboard

Published 20 hours ago • verified publisher icon OSGeo

Fix -Wsometimes-uninitialized compiler warnings

Open nilason opened this issue 3 years ago • 2 comments

As reported in #2156.

Initially this is a draft, I commented in code to highlight the sometimes uninitialised variables. We need to decide how to address them.

Affects:

Modules

  • db/drivers/ogr
  • d.vect.thematic
  • i.eb.soilheatflux
  • r.buffer
  • r.fill.stats
  • r.resamp.rst
  • r3.in.bin
  • r3.in.v5d
  • r3.out.bin
  • r3.out.v5d
  • v.normal
  • v.proj
  • v.sample
  • v.to.rast3

GRASS Library parts

  • lib/imagery
  • lib/ogsf
  • lib/raster3d
  • lib/vector/Vlib

nilason avatar Feb 04 '22 12:02 nilason

Can you please move the CodeQL errors to a separate PR? They are unrelated and likely we can merge them much sooner.

wenzeslaus avatar Feb 04 '22 19:02 wenzeslaus

I merged this with main which resolved conflicts, but it needs some additional clean up because now it would revert some changes which happened on main in the same files. Given that this is a draft without any actual code changes, I'm leaving it as is for now.

wenzeslaus avatar Sep 07 '22 08:09 wenzeslaus

Finalised the rebase, to be able to continue with clean sheets.

nilason avatar Oct 28 '22 16:10 nilason

Opening this for review. I left the comments temporarily for context, I will remove them before merge.

nilason avatar Oct 31 '22 20:10 nilason

This is now ready, I'll proceed to merge soon if there are no objections.

nilason avatar Nov 07 '22 16:11 nilason