grass icon indicating copy to clipboard operation
grass copied to clipboard

wxGUI: Add the ProjPicker page to the Location Wizard (Continutation)

Open ocsmit opened this issue 4 years ago • 8 comments

This pull request is a continuation of the work of #1770 in addressing #1253 to add a location wizard which is spatially queryable.

The goals/scope of the continuation are

  • Inclusion of toolbar for users. 1
  • Smoother OSM map loading (e.g. lazy loading, separate thread, ...). 2
  • Merge with standard EPSG search wizard. 2

@HuidaeCho Feel free to add anything I missed!

ocsmit avatar Sep 26 '21 00:09 ocsmit

I think the problem with this replacing the current default is that it requires an Internet connection. We should either

  1. add it as the default, but keep the EPSG search or
  2. check for an Internet connection and enable it if available, otherwise fall back to the EPSG search (what if data is expensive?)

HuidaeCho avatar Dec 13 '21 16:12 HuidaeCho

You’d be helped by checking the Python with Flake8, there are a few not insignificant warnings. For one, you should consider using raw strings (r”…”) for regex patterns.

nilason avatar Feb 07 '22 22:02 nilason

Pan and draw icons are now functional. @ocsmit, do we need more icons?

image

HuidaeCho avatar May 20 '22 09:05 HuidaeCho

There is an issue in the Summary window with wxPython 4.1.1.

image

HuidaeCho avatar May 20 '22 09:05 HuidaeCho

Pan and draw icons are now functional. @ocsmit, do we need more icons?

That should be all that we need. Appreciate you making them functional.

There is an issue in the Summary window with wxPython 4.1.1.

I can not recreate the description issue on my machine, see below grass-ppik

System Info                                                                     
GRASS version: 8.0.dev                                                          
Code revision: 80cb7f91a                                                        
Build date: 2022-05-20                                                          
Build platform: x86_64-pc-linux-gnu                                             
GDAL: 3.0.4                                                                     
PROJ: 6.3.1                                                                     
GEOS: 3.8.0                                                                     
SQLite: 3.31.1                                                                  
Python: 3.8.10                                                                  
wxPython: 4.1.1                                                                 
Platform: Linux-5.4.0-110-generic-x86_64-with-glibc2.29 

ocsmit avatar May 20 '22 15:05 ocsmit

Flake8 is happy with

l, r = 1, 2

but not with

l, O = 1, 2

and

l = 1
r = 2

Inconsistency... As a result, we have inconsistent naming.

  • l, r, t, b
  • le, ri, to, bo
  • left, right, top, bottom
  • n, s, w, e
  • north, south, west, east

Many short variable names fail Pylint testing because this new module is not excluded from .pylintrc.

HuidaeCho avatar May 21 '22 14:05 HuidaeCho

Working on pylint...

HuidaeCho avatar May 21 '22 15:05 HuidaeCho