grass icon indicating copy to clipboard operation
grass copied to clipboard

t.rast.algebra temporal neighbourhood modifier not clearly documented

Open mankoff opened this issue 5 years ago • 6 comments
trafficstars

The temporal neighbourhood modifier states The format is strds[t,r,c], where t is the temporal offset, r is the row offset and c is the column offset but never explicitly states what behavior occurs if <3 elements are provided.

From the example, it appears 1 value is assumed to be t, 2 is r,c, and 3 is t,r,c? This is confusing, as the 1st element is sometimes treated as t and other times as r. It would be good to explicitly state this if this is the case.

https://github.com/OSGeo/grass/blob/7d9a0da4fcf603bf690e470176a488e2def05d49/temporal/t.rast.algebra/t.rast.algebra.html#L444-L475

mankoff avatar Nov 04 '20 01:11 mankoff

Shall this still go into the upcoming 7.8.5?

neteler avatar Dec 05 '20 10:12 neteler

#905 adds new temporal functions and updates documentation. Should I take the documentation part related to this issue out of the PR so it can go into 7.8.6 separately?

ninsbl avatar Dec 07 '20 07:12 ninsbl

Will the new feature be available only in grass 8.0? If yes, then the clarifications in documentation related to this issue should probably go in a separate PR, IMO

veroandreo avatar Dec 07 '20 17:12 veroandreo

#905 adds new temporal functions and updates documentation. Should I take the documentation part related to this issue out of the PR so it can go into 7.8.6 separately?

If you could separate out the doc updates (relevant for G7.8.6) in a new PR... thanks

neteler avatar Apr 21 '21 17:04 neteler

Bumped to 8.0.1

neteler avatar Jan 20 '22 21:01 neteler

Should be backported to 8.2 (and also 7.8)

ninsbl avatar Mar 10 '23 21:03 ninsbl

This got fixed with #905 in 8.3. Given that 8.4 is on it`s way I close this issue (as backporting to GRASS GIS 7 is not planned).

ninsbl avatar May 30 '24 09:05 ninsbl