community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

feat: add image upload to questions

Open Robert-LC opened this issue 1 year ago • 2 comments

PR Checklist

PR Type

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Developer experience (improves developer workflows for contributing to the project)

Description

Add image upload to questions

Git Issues

Closes #3321

Screenshots/Videos

image image

Also as a side note for a separate issue I think refactors might of introduced a styling bug, because I don't believe it did this when I was adding this code before the refactors. Tags drop down messes up footer

image

Robert-LC avatar Mar 16 '24 01:03 Robert-LC

It was my code that caused it, fixing now

Robert-LC avatar Mar 17 '24 20:03 Robert-LC

So I found a partial fix for the tags field moving the footer around,

If I move tags to be above the new images input it won't have that problem, because its far enough away but it doesn't fix the root problem

image

I tried to investigate the CSS, and setting the tags dropdown to 'position absolute' breaks its positioning in the card container and with its length, but it fixes the dropdown issue.

image

Couldn't find in the code to alter the CSS for the dropdown part only and not the component in its non active state

Robert-LC avatar Mar 21 '24 03:03 Robert-LC

Visit the preview URL for this PR (updated for commit c2832d2):

https://onearmy-next--pr3366-feat-questions-add-i-jpehxf5x.web.app

(expires Fri, 26 Apr 2024 17:03:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59

github-actions[bot] avatar Mar 26 '24 03:03 github-actions[bot]

Codecov Report

Attention: Patch coverage is 64.28571% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 65.79%. Comparing base (76273e3) to head (c2832d2). Report is 6 commits behind head on master.

Files Patch % Lines
src/stores/Question/question.store.tsx 20.00% 8 Missing :warning:
src/pages/Question/Content/Common/QuestionForm.tsx 87.50% 1 Missing :warning:
src/pages/Question/QuestionPage.tsx 50.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3366      +/-   ##
==========================================
- Coverage   65.81%   65.79%   -0.02%     
==========================================
  Files         416      417       +1     
  Lines       13458    13481      +23     
  Branches     2483     2494      +11     
==========================================
+ Hits         8857     8870      +13     
- Misses       4549     4559      +10     
  Partials       52       52              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 27 '24 15:03 codecov[bot]

Passing run #5336 ↗︎

0 99 0 0 Flakiness 0

Details:

chore: fix linting
Project: onearmy-community-platform Commit: c2832d2d91
Status: Passed Duration: 04:49 💡
Started: Mar 27, 2024 3:43 PM Ended: Mar 27, 2024 3:48 PM

Review all test suite changes for PR #3366 ↗︎

cypress[bot] avatar Mar 27 '24 15:03 cypress[bot]

@all-contributors please add @Robert-LC for code

benfurber avatar Mar 27 '24 16:03 benfurber

@benfurber

I've put up a pull request to add @Robert-LC! :tada:

allcontributors[bot] avatar Mar 27 '24 16:03 allcontributors[bot]

:tada: This PR is included in version 1.166.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Mar 27 '24 17:03 onearmy-bot