community-platform
community-platform copied to clipboard
fix: how-to most useful sort
PR Checklist
- [x] - Commit messages are descriptive, it will be used in our Release Notes
PR Type
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Developer experience (improves developer workflows for contributing to the project)
Description
- Fixes how-to most useful sort
- Fixes display of useful count on how-to list for cards with long title
Git Issues
Closes #
Screenshots/Videos
If useful, provide screenshot or capture to highlight main changes
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.
Codecov Report
Patch coverage: 66.66% and project coverage change: -0.58 :warning:
Comparison is base (
6c18475) 43.30% compared to head (bfb515f) 42.73%.
Additional details and impacted files
@@ Coverage Diff @@
## master #2453 +/- ##
==========================================
- Coverage 43.30% 42.73% -0.58%
==========================================
Files 259 259
Lines 7172 7168 -4
Branches 1567 1566 -1
==========================================
- Hits 3106 3063 -43
- Misses 4035 4077 +42
+ Partials 31 28 -3
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/pages/Howto/Content/HowtoList/HowToCard.tsx | 0.00% <ø> (ø) |
|
| src/pages/Howto/Content/HowtoList/HowtoList.tsx | 0.00% <ø> (ø) |
|
| src/pages/Howto/Content/HowtoList/SortSelect.tsx | 0.00% <0.00%> (ø) |
|
| src/test/factories/Howto.ts | 100.00% <ø> (ø) |
|
| src/stores/Howto/howto.store.tsx | 67.91% <100.00%> (+2.50%) |
:arrow_up: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
2 flaky tests on run #3672 ↗︎
Details:
| test: sort howtos by useful count | |||
| Project: onearmy-community-platform | Commit: bfb515fe75 |
||
| Status: Passed | Duration: 03:55 💡 | ||
| Started: Jun 22, 2023 10:18 AM | Ended: Jun 22, 2023 10:22 AM | ||
research/write.spec.ts • 1 flaky test • ci-chrome
| Test | Artifacts | |
|---|---|---|
| [Research] > [Edit a research article] > [By Owner] |
Output
Screenshots
|
|
common.spec.ts • 1 flaky test • ci-chrome
| Test | Artifacts | |
|---|---|---|
| [Common] > [User Menu] > [By Authenticated] |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
:tada: This PR is included in version 1.66.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: