community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

[feature request] Change the style of delete buttons

Open BaltacMihai opened this issue 2 years ago • 4 comments

Is your feature request related to a problem? Please describe. There doesn't appear to be any distinction between the importance of the buttons on the http://localhost:3000/settings page's final section, the one with "Change Email," "Change Password," and "Delete Profile," which may effect accessibility.

Describe the solution you'd like A red background should be used for all buttons that have "destructive" behavior, or the ability to erase something, according to studies.

Describe alternatives you've considered Another method to distinguish these buttons

Additional context Several studies that support the issue:

https://uxmovement.com/buttons/how-to-design-destructive-actions-that-prevent-data-loss/ https://uxstepbystep.com/delete-buttons-red-green/

BaltacMihai avatar Jun 20 '23 19:06 BaltacMihai

Can I work on this issue?

AlimurtuzaCodes avatar Jun 21 '23 06:06 AlimurtuzaCodes

I think we need the ok from Maintainers

BaltacMihai avatar Jun 21 '23 07:06 BaltacMihai

Can you hold on this one please, I agree with the suggestion but some of the projects colour themes already use orange/red buttons so think it needs some input from someone on the design side. @davehakkens - thoughts?

iSCJT avatar Jun 21 '23 08:06 iSCJT

Yeah this might be an issue like @iSCJT mentioned, would have to look into the color usage for the buttons across the platform. Precious plastic for example uses red as the primary across different buttons. Tough to bring uniformity when we have color variants for the different platforms.

AlfonsoGhislieri avatar Jun 21 '23 21:06 AlfonsoGhislieri

Making the entire section different, as it was on github.

I saw that this was available in the application's profile -> admin settings section. I believe it is okay to use a red background for the sections and to provide some warning symbols to alert users when their actions may change their accounts.

Capture

BaltacMihai avatar Jun 26 '23 09:06 BaltacMihai

Using the red background like for admins makes sense to me @BaltacMihai, go for it! :)

davehakkens avatar Jun 26 '23 18:06 davehakkens

If @CYBWEBALI changed his mind, I can work, but he said the first time that he wanted to work.

BaltacMihai avatar Jun 26 '23 19:06 BaltacMihai

If @CYBWEBALI changed his mind, I can work, but he said the first time that he wanted to work.

Yeah sure you can work on this.

AlimurtuzaCodes avatar Jun 27 '23 04:06 AlimurtuzaCodes

:tada: This issue has been resolved in version 1.69.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Jun 27 '23 10:06 onearmy-bot