community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

fix: remove use of theme from ProfileButtons

Open BaltacMihai opened this issue 2 years ago • 2 comments

PR Checklist

PR Type

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] Developer experience (improves developer workflows for contributing to the project)

Description

Removes direct usage of the theme object, instead accessing it within the sx property.

Git Issues

Closes #2302

BaltacMihai avatar Jun 20 '23 18:06 BaltacMihai

Codecov Report

Patch coverage has no change and project coverage change: -0.71 :warning:

Comparison is base (6c18475) 43.30% compared to head (53f8a3c) 42.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2448      +/-   ##
==========================================
- Coverage   43.30%   42.60%   -0.71%     
==========================================
  Files         259      259              
  Lines        7172     7171       -1     
  Branches     1567     1567              
==========================================
- Hits         3106     3055      -51     
- Misses       4035     4088      +53     
+ Partials       31       28       -3     
Impacted Files Coverage Δ
...ages/common/Header/Menu/Profile/ProfileButtons.tsx 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jun 20 '23 19:06 codecov[bot]

1 flaky tests on run #3659 ↗︎

0 90 0 0 Flakiness 1

Details:

Merge branch 'master' into ProfileButtons
Project: onearmy-community-platform Commit: 53f8a3c460
Status: Passed Duration: 04:02 💡
Started: Jun 20, 2023 7:00 PM Ended: Jun 20, 2023 7:04 PM
Flakiness  src/integration/research/write.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Research] > [Edit a research article] > [By Owner] Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

cypress[bot] avatar Jun 20 '23 19:06 cypress[bot]

:tada: This PR is included in version 1.65.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Jun 22 '23 19:06 onearmy-bot