community-platform
community-platform copied to clipboard
feat: add Apply button to map filters on mobile
PR Checklist
- [x] - Commit messages are descriptive, it will be used in our Release Notes
PR Type
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Developer experience (improves developer workflows for contributing to the project)
Description
Added "Apply" button to the filters modal. Some auxiliary changes:
- Bound single instance of
toggleFilterMobileModalfunction to a component to avoid creating multiple functions on every render; - Moved the block with "close cross" icon inside of
<GroupingFilterMobile>.- This helped to generalise
onCloseinterface a bit. And it made sense to keep them together, although let me know if you think it would've been better to keep them separate.
- This helped to generalise
- Extended breakpoint for
<GroupingFilterMobile>to appear on tablets as well. - Left some other minor changes, please see open threads.
Git Issues
Closes #1852
Screenshots/Videos

Test summary
Run details
| Project | onearmy-community-platform |
| Status | Passed |
| Commit | 7ecbdba47c |
| Started | Oct 25, 2022 9:44 PM |
| Ended | Oct 25, 2022 9:46 PM |
| Duration | 02:44 💡 |
| OS | Linux Ubuntu - 20.04 |
| Browser | Chrome 107 |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
Visit the preview URL for this PR (updated for commit 7ecbdba):
https://onearmy-next--pr1985-1852-map-mc5emn7d.web.app
(expires Thu, 01 Dec 2022 09:35:09 GMT)
🔥 via Firebase Hosting GitHub Action 🌎
Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59
Looking great with me! Thank you @Sc4ramouche. Maybe as you are at it could you extend the functionality to pad breakpoint too?
Hey @thisismattia, I've extended the breakpoint for this UI, please see the GIFs:


thank you! that's great 👍 Good to go for me!
Nice, thanks! Waiting for the code review in this case 🙏
Heja @chrismclarke @asheerrizvi, thanks for your reviews and suggestions 👍 I think this PR is now in a good shape thanks to your contributions, feel free to initiate the merge 🙌
Thanks again @Sc4ramouche and for addressing all the suggestions. Looks good to go!
:tada: This PR is included in version 1.30.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: