community-platform
community-platform copied to clipboard
Prefactor: Email notifications
PR Checklist
- [X] - Commit messages are descriptive, it will be used in our Release Notes
PR Type
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [X] Developer experience (improves developer workflows for contributing to the project)
Description
- Adds
notification_settingstoIUser - Refactors notification store
userNotificationsStoreout of user store - Adds new state for notifications
notified - Marks all notifications in notification list as
notifiedwhen opened
See: https://docs.google.com/document/d/1dC_sKVLcSCggFftPFRcB1F5wt4ABQDtmVOX0oQGdXUw/edit#heading=h.crtcwv7i47zb
Note: I can't base off of #1900 so theres duplicate diff related to docker stuff, will be fixed with a rebase
@adrianduke, have you had a chance to review https://github.com/ONEARMY/community-platform/pull/1789? I think it would be preferable to merge that work first and think it will impact the prefactor work you've started here.
In an effort to unblock the work on this branch, I've taken the @mention capability without notifications out of #1789 and created a new PR #1930 to see that change merged.
This means we can move forward on the prefactoring work here and look to reference #1789 on the logic of how to handle @mention notifications. Not necessarily as part of this change but at a later date.
I have also merged #1900, so you can rebase @adrianduke
Let me know @adrianduke if you are still able to wrap this one up. Otherwise we will either have to start from scratch or try to built on top of this.
Test summary
Run details
| Project | onearmy-community-platform |
| Status | Passed |
| Commit | e085a0b2e6 |
| Started | Dec 7, 2022 6:36 AM |
| Ended | Dec 7, 2022 6:39 AM |
| Duration | 03:19 💡 |
| OS | Linux Ubuntu - 20.04 |
| Browser | Chrome 108 |
View run in Cypress Dashboard ➡️
Flakiness
|
|
src/integration/common.spec.ts |
1 |
|
|---|---|---|---|
| 1 | [Common] > [User Menu] > [By Authenticated] |
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
:tada: This PR is included in version 1.32.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: