community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

fix: settings height for mobile devices

Open asheerrizvi opened this issue 3 years ago • 3 comments

PR Checklist

PR Type

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Developer experience (improves developer workflows for contributing to the project)

Description

Fixes "settings" height for mobile devices.

Git Issues

Closes #1844

Screenshots/Videos

https://user-images.githubusercontent.com/17976252/184066472-5b423e87-f7b8-4827-bb12-46758507cf2d.mov


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on slack in the platform-dev channel.

asheerrizvi avatar Aug 11 '22 04:08 asheerrizvi

Visit the preview URL for this PR (updated for commit b77224f):

https://onearmy-next--pr1885-fix-1844-zax5gyve.web.app

(expires Fri, 16 Sep 2022 06:04:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot] avatar Aug 11 '22 07:08 github-actions[bot]

Nice one! all working ✌️

thisismattia avatar Aug 11 '22 08:08 thisismattia

@thisislawatts I think we can merge this now.

asheerrizvi avatar Aug 14 '22 08:08 asheerrizvi



Test summary

59 0 0 0Flakiness 1


Run details

Project onearmy-community-platform
Status Passed
Commit b77224fb13
Started Aug 17, 2022 5:28 AM
Ended Aug 17, 2022 5:32 AM
Duration 03:15 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️


Flakiness

src/integration/howto/write.spec.ts Flakiness
1 [How To] > [Edit a how-to] > [By Owner]

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 17 '22 05:08 cypress[bot]

:tada: This PR is included in version 1.20.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Aug 17 '22 05:08 onearmy-bot