community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

feat(functions): updating user info in research post & comments

Open danitrod opened this issue 3 years ago • 1 comments

PR Checklist

PR Type

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Developer experience (improves developer workflows for contributing to the project)

Description

My last PR only included the fixed functionality for updating user info in howto's, but ignored research modules. This PR adds functionality to update user data in researches whenever it changes.

Also, answering to @thisislawatts' comment in the last PR, currently I am testing manually as I'm not sure how to write tests for the backend Firebase functions. Do we have any test for those yet? Indeed that some automation would be very welcome for testing this behaviour.

Git Issues

Closes #1469 (already closed but this part was missing)

danitrod avatar Aug 11 '22 03:08 danitrod



Test summary

59 0 0 0Flakiness 0


Run details

Project onearmy-community-platform
Status Passed
Commit bb60dc62cb
Started Aug 11, 2022 3:51 AM
Ended Aug 11, 2022 3:55 AM
Duration 03:05 💡
OS Linux Ubuntu - 20.04
Browser Chrome 104

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Aug 11 '22 03:08 cypress[bot]

@all-contributors add @danitrod for code

thisislawatts avatar Sep 12 '22 05:09 thisislawatts

@thisislawatts

I've put up a pull request to add @danitrod! :tada:

allcontributors[bot] avatar Sep 12 '22 05:09 allcontributors[bot]

:tada: This PR is included in version 1.22.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Sep 13 '22 18:09 onearmy-bot