community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

Published 20 hours ago • verified publisher icon ONEARMY

[bug] Cant edit or delete comments

Open davehakkens opened this issue 3 years ago • 2 comments

Describe the bug The edit and delete feature doesnt work in comments. For both the research module and the how-to's

  1. In the research module the button is there but non clickable
  2. in How-to's the Remove and Edit button are not present

This probably got broken when migrating the component In this https://github.com/ONEARMY/community-platform/pull/1742 or this https://github.com/ONEARMY/community-platform/pull/1772 one

To Reproduce Steps to reproduce the behaviour:

  1. Login deviste
  2. Leave a comment in research or howto
  3. try to edit or delete

Screenshots In research module after leaving a comment afbeelding In how-to after leaving a comment afbeelding

davehakkens avatar Aug 04 '22 16:08 davehakkens

@davehakkens I can work on this :D

asheerrizvi avatar Aug 11 '22 07:08 asheerrizvi

that would be great @asheerrizvi! Let me know if you need any help :)

davehakkens avatar Aug 11 '22 07:08 davehakkens

The delete worked for me on mobile. The delete confirmation appeared to be an iOS dialog and not the delete confirmation dialog seen in other areas.

cschilbe avatar Aug 18 '22 02:08 cschilbe

Thanks for letting us know @cschilbe are you still on this @asheerrizvi?

davehakkens avatar Aug 18 '22 11:08 davehakkens

@davehakkens haven't been able to start on this as of now.

asheerrizvi avatar Aug 18 '22 11:08 asheerrizvi

Guys, delete was already working. Have fixed the issue with editing the comment. Here's the PR: https://github.com/ONEARMY/community-platform/pull/1901

asheerrizvi avatar Aug 20 '22 10:08 asheerrizvi

:tada: This issue has been resolved in version 1.23.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Sep 14 '22 06:09 onearmy-bot