community-platform icon indicating copy to clipboard operation
community-platform copied to clipboard

Feat/emulator runtime config

Open chrismclarke opened this issue 3 years ago • 1 comments

PR Checklist

PR Type

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [x] Developer experience (improves developer workflows for contributing to the project)

TODO

  • [x] Builds from #1805 so should be updated after merge for clean diff

Description

A few minor bits of housekeeping related to docker emulators, namely:

  • Add support for runtimeconfig within docker emulators (same way that we use to test functions emulator locally)

  • Update emulator seed data. This is mostly just because it is currently the only way to force a rebuild of the emulator core which is required as the package.json dependencies have been updated recently. I was hoping to update from the fixed automated weekly export (instead of usual manually triggered export), however this needs a few minor tweaks first (see below) so created manual export. Hopefully should open pathway after for automating the full process

  • Remove user revisions subcollection - these are quite large and just not very well thought out (keep copy of entire user profile when states change, but really should just track diffs - will add issue to address). Given that we create a weekly backup anyway no reason each should contain full history of user profile modifications

  • Tidy jest runtime config setup scripts to allow config to also be imported into docker build.

  • Minor docker build logging updates

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on slack in the platform-dev channel.

chrismclarke avatar Jun 28 '22 19:06 chrismclarke



Test summary

47 0 0 0Flakiness 0


Run details

Project onearmy-community-platform
Status Passed
Commit c4eba95b71
Started Oct 22, 2022 9:56 PM
Ended Oct 22, 2022 9:59 PM
Duration 02:46 💡
OS Linux Ubuntu - 20.04
Browser Chrome 106

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Jun 28 '22 19:06 cypress[bot]

As this shouldn't have any real knock-ons elsewhere I think safe to unblock and just merge

chrismclarke avatar Oct 22 '22 22:10 chrismclarke

:tada: This PR is included in version 1.29.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

onearmy-bot avatar Oct 23 '22 11:10 onearmy-bot