android-app icon indicating copy to clipboard operation
android-app copied to clipboard

F-Droid build failed

Open linsui opened this issue 1 year ago • 22 comments

:writing_hand: Describe the bug

https://gitlab.com/fdroid/fdroiddata/-/jobs/8017535739 The wear os deps are not FOSS. Could you please provide a FOSS flavor for F-Droid? Thanks!

:bomb: Steps to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

:wrench: Expected behavior

:camera: Screenshots

:iphone: Tech info

  • Device:
  • OS:
  • App Version:

:page_facing_up: Additional context

linsui avatar Oct 08 '24 05:10 linsui

Thanks for reporting the issue, @linsui. May you simply ignore the whole wear folder?

OMGSoundboard avatar Oct 10 '24 16:10 OMGSoundboard

Isn't that tied in the main code?

licaon-kter avatar Oct 10 '24 16:10 licaon-kter

Isn't that tied in the main code?

No, the smartwatch Wear OS by Google part is independent from the smartphone part. Am I wrong, @Rashxz?

OMGSoundboard avatar Oct 10 '24 17:10 OMGSoundboard

It's not that case anymore. https://github.com/OMGSoundboard/android-app/pull/100 added wear related features in the main app.

linsui avatar Oct 10 '24 18:10 linsui

Isn't that tied in the main code?

No, the smartwatch Wear OS by Google part is independent from the smartphone part. Am I wrong, @Rashxz?

The main app also has the wear play services library to comunicate and sync data. I'll make a flavor to leave that part out.

Rashxz avatar Oct 11 '24 16:10 Rashxz

May you please try if v13.0 builds again on F-Droid, @linsui?

OMGSoundboard avatar Nov 02 '24 10:11 OMGSoundboard

https://github.com/OMGSoundboard/android-app/blob/v13.0/core/build.gradle#L48 This is not FOSS. Could you please remove this from foss flavor?

linsui avatar Nov 02 '24 18:11 linsui

https://github.com/OMGSoundboard/android-app/blob/v13.0/core/build.gradle#L48 This is not FOSS. Could you please remove this from foss flavor?

Forgot that was there sorry. Removed.

Rashxz avatar Nov 02 '24 21:11 Rashxz

https://github.com/OMGSoundboard/android-app/blob/v13.0/sync_manager/build.gradle#L54 This lib depends on GMS.

linsui avatar Nov 03 '24 05:11 linsui

https://github.com/OMGSoundboard/android-app/blob/v13.0/sync_manager/build.gradle#L54 This lib depends on GMS.

moved, do you see any other lib that is not foss?

Rashxz avatar Nov 04 '24 14:11 Rashxz

No, it should be good now. :)

linsui avatar Nov 04 '24 15:11 linsui

I created a new release and hope it builds now. 🫡

OMGSoundboard avatar Nov 04 '24 21:11 OMGSoundboard

https://github.com/OMGSoundboard/android-app/blob/development/core/build.gradle#L44 I didn't notice this, sorry... Could you please also remove it?

linsui avatar Nov 05 '24 05:11 linsui

Removed

Rashxz avatar Nov 06 '24 23:11 Rashxz

I created a new release and hope it builds now. 😀

OMGSoundboard avatar Nov 12 '24 21:11 OMGSoundboard

still fails: https://gitlab.com/fdroid/fdroiddata/-/jobs/8342676205#L658

diff log: omg17.log

licaon-kter avatar Nov 13 '24 09:11 licaon-kter

v17.0 fails RB at IzzyOnDroid as well btw, with a huge diff in classes2.dex: diffs.zip

Do you still build with JDK-17 as your workflow states? Well, results with JDK-21 were identical, so that's not it. Built from a clean tree – or any local changes/artifacts/caches?

IzzySoft avatar Nov 13 '24 19:11 IzzySoft

I suppose @Rashxz is already looking into it. I have no clue at the moment, sorry.

OMGSoundboard avatar Nov 14 '24 18:11 OMGSoundboard

Fingers crossed then! As discussed on "the other channel", v17.0 is marked "RB failed" now (afraid we cannot "rescue" that one) – but that "mark" will age out with future releases hopefully matching up again :crossed_fingers:

IzzySoft avatar Nov 14 '24 22:11 IzzySoft

Kindly ping. :) Any update here?

linsui avatar Feb 22 '25 08:02 linsui

Sorry for the delay, @linsui. We can try a new build v18.0 next month.

OMGSoundboard avatar Feb 22 '25 19:02 OMGSoundboard

This month was too busy so the next release is possible next month at the earliest. 🙈

OMGSoundboard avatar Mar 23 '25 22:03 OMGSoundboard

Kindly ping. :)

linsui avatar Jun 26 '25 07:06 linsui

Kindly ping. :)

Sorry for the delay, @linsui. We will try it next month.

OMGSoundboard avatar Jun 28 '25 09:06 OMGSoundboard

The Foss one is RB here.

IzzySoft avatar Aug 06 '25 22:08 IzzySoft

FOSS confirmed for F-Droid too 👍

@OMGSoundboard ping us when a release is ready

licaon-kter avatar Aug 07 '25 09:08 licaon-kter

Thanks everyone! 😍 The new release is ready, @licaon-kter & @IzzySoft.

OMGSoundboard avatar Aug 07 '25 17:08 OMGSoundboard

It already passed our second builder, but missed the repo updater by just 15 minutes 🙈 Will be part of the next sync then.

IzzySoft avatar Aug 07 '25 19:08 IzzySoft

Thanks, unfortunately, AGP 8.12.0 doesn't work on our old buildserver. Could you please downgrade it?

linsui avatar Aug 08 '25 02:08 linsui