core icon indicating copy to clipboard operation
core copied to clipboard

Refactor "ocrd process" to be interoperable with OCR-D/spec#171

Open kba opened this issue 5 years ago • 1 comments

  • ValidationReport -> ocrd_models
  • Decouple parsing and validation of tasks into OcrdWf (workflow), OcrdWfStep and OcrdWfValidator

kba avatar Aug 15 '20 16:08 kba

Codecov Report

Merging #566 into master will increase coverage by 0.32%. The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   84.15%   84.48%   +0.32%     
==========================================
  Files          48       51       +3     
  Lines        2752     2868     +116     
  Branches      538      559      +21     
==========================================
+ Hits         2316     2423     +107     
- Misses        339      347       +8     
- Partials       97       98       +1     
Impacted Files Coverage Δ
ocrd_models/ocrd_models/report.py 100.00% <ø> (ø)
ocrd_models/ocrd_models/ocrd_wf.py 50.00% <50.00%> (ø)
...rd_validators/ocrd_validators/ocrd_wf_validator.py 94.23% <94.23%> (ø)
ocrd/ocrd/cli/validate.py 100.00% <100.00%> (ø)
ocrd_models/ocrd_models/__init__.py 100.00% <100.00%> (ø)
ocrd_models/ocrd_models/constants.py 100.00% <100.00%> (ø)
ocrd_models/ocrd_models/ocrd_wf_step.py 100.00% <100.00%> (ø)
ocrd_validators/ocrd_validators/__init__.py 100.00% <100.00%> (ø)
ocrd_validators/ocrd_validators/json_validator.py 100.00% <100.00%> (ø)
...d_validators/ocrd_validators/ocrd_zip_validator.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc3ffe4...bf8d1b1. Read the comment docs.

codecov-commenter avatar Aug 15 '20 17:08 codecov-commenter

This is now very obsolete, we decided to use nextflow for productive workflows. ocrd process as it-is is enough for simple workflows, so it is beyond time to close this.

kba avatar Nov 30 '22 15:11 kba

Agreed. Can we get something similar in core based on OtoN, though?

bertsky avatar Nov 30 '22 16:11 bertsky