core icon indicating copy to clipboard operation
core copied to clipboard

Resolver.workspace_from_url: usage of clobber_mets not consistent with the docstring

Open hnesk opened this issue 5 years ago • 2 comments
trafficstars

clobber_mets = False does not raise an exception for existing mets.xml ('raise'), but fails silently ('skip') https://github.com/OCR-D/core/blob/4e11b8e70a2426f3d25466f462db13bf31215919/ocrd/ocrd/resolver.py#L114 see: https://github.com/OCR-D/core/blob/4e11b8e70a2426f3d25466f462db13bf31215919/ocrd/ocrd/resolver.py#L154

I don't know what would be the right thing to do: Fix the docstring or fix the implementation?

hnesk avatar Aug 13 '20 09:08 hnesk

I don't know what would be the right thing to do: Fix the docstring or fix the implementation?

I'd prefer the latter option.

bertsky avatar Aug 13 '20 10:08 bertsky

Oh, I just found this PR https://github.com/OCR-D/core/pull/425#pullrequestreview-346994175

hnesk avatar Aug 18 '20 17:08 hnesk