OpenAPI-Specification icon indicating copy to clipboard operation
OpenAPI-Specification copied to clipboard

Published 20 hours ago • verified publisher icon OAI

ReSpec HTML generation needs to use correct revision of MAINTAINERS.md

Open handrews opened this issue 1 year ago • 3 comments

As seen in PR #3688, scripts/md2html fails to use the correct revision of the MAINTAINERS.md file for the 3.0 and 3.1 specifications. Specifically, build.sh uses a specific revision for the 2.0 spec, but not for the later specs. Also, the collection of emeritus members in md2html.js seems to no longer work with the current file format.

handrews avatar Apr 03 '24 17:04 handrews

Would it make sense to version the maintainer files?

lornajane avatar Apr 18 '24 13:04 lornajane

The build script expects "Emeritus" to be the second unordered list: https://github.com/OAI/OpenAPI-Specification/blob/64111cc3aa5a59ffc631a4987a87550691a35584/scripts/md2html/md2html.js#L121-L125

Now the second list is "Provisional".

Should provisional maintainers be

  1. ignored, or
  2. treated identical to "Active"?

ralfhandl avatar May 06 '24 07:05 ralfhandl

Special case for version 2.0 is incorrect as the history of Maintainers.md starts too late, and the first commit already lists two members as "Emeritus" who were still active when version 2.0 was published.

ralfhandl avatar May 06 '24 07:05 ralfhandl