python-o365 icon indicating copy to clipboard operation
python-o365 copied to clipboard

Published 20 hours ago • verified publisher icon O365

HTML or html body_type in all references

Open Naxest opened this issue 4 years ago • 5 comments

This line is the only one which the body_type = "html" is in lower case. Should it be in uppercase like the rest of references?

https://github.com/O365/python-o365/blob/6df9fb1c79f465f22d621cf024a15f01caa02943/O365/message.py#L406

Naxest avatar May 13 '21 12:05 Naxest

i don't think so

alejcas avatar May 13 '21 12:05 alejcas

Why the default value of body_type is "HTML" with upper case? https://github.com/O365/python-o365/blob/5081c944f49443c7d797266fbcdb0b0133284077/O365/message.py#L283

Thank you

Naxest avatar May 14 '21 09:05 Naxest

The default is html.

why is upper case? I don’t remember why… If there’s a. Bug please submit a PR.

Thanks

alejcas avatar May 14 '21 11:05 alejcas

Thank you, I'll investigate and try it and if I find out an issue I'll submit a PR.

Naxest avatar May 19 '21 16:05 Naxest

Thanks

alejcas avatar May 19 '21 16:05 alejcas