ormx
ormx copied to clipboard
Add a mechanism to describe partial updates
I think it would be valuable to add a mechanism for partial updates to ormx similar to what the AsChangeset derive from diesel does.
There are however various possible solutions, the most straightforward one being to require all fields in Patch structs to be wrapped in an Option:
Nonewould not perform the update for the fieldSome(None)would set a nullable field toNULLSome(Some(val))would set a nullable field tovalSome(val)would set a non-nullable field toval
I started discussing this on the discord and @NyxCode kindly responded with interesting alternative ideas that I think are very much worth exploring. I'm quoting their message here to help start the discussion:
yeah so I did think about this a bit in the past. I found that in most cases, it's most comfortable to avoid having to deal with nested Options and stuff like you would have to with diesel. That's also what I needed the most at the time. I do think supporting this would be great though! Would having an attribute like
#[ormx(ignore_if_none)](that name is mediocre, im sure we can come up with something better) work when derivingPatch? I guess we would need something a bit more sophisticated when we still want to be able to derivePatchfor the same struct which represents theTableRegardless, I'd definetely appraciate if you would open an issue for this, possibly outlining possible approaches like this